-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: correct peformance entry types #54263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit: shall we reorder them alphabetically?
e.g. 'dns', 'function', 'gc', 'http', ...
91d45f5
to
31d4f56
Compare
@jakecastelli Sounds good 👍 reordered the entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So |
This comment was marked as outdated.
This comment was marked as outdated.
@Semigradsky Pretty sure the doc is outdated and |
Ok, I see that we have Base class can't be more narrow, so |
Fixes: nodejs#54212 Fixes: nodejs#50290
31d4f56
to
0dabfa0
Compare
I overlooked that. I think you are right @Semigradsky after checking the implementation. Thank you for pointing it out. I have updated the PR I think previously, this PR did not remove the 'node' type but hide it as an unsupported one, so that observer does not track it |
Landed in e020dd8 |
Fixes: #54212
Fixes: #50290