Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update amaro to 0.1.6 #54374

Closed
wants to merge 1 commit into from
Closed

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of amaro to 0.1.6.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 14, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 14, 2024
@marco-ippolito
Copy link
Member

marco-ippolito commented Aug 14, 2024

I added the commit with the new flag nativeClassProperties.
This flag does not make any behavior change at runtime, and is it tested inside amaro, but allows to emit the same code as TS compiler.
This commit fixes nodejs/typescript#3

Actually I'll do that in a followup PR

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (c1ec099) to head (7599df0).
Report is 402 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54374      +/-   ##
==========================================
- Coverage   87.08%   87.08%   -0.01%     
==========================================
  Files         648      648              
  Lines      182217   182217              
  Branches    34956    34955       -1     
==========================================
- Hits       158684   158681       -3     
- Misses      16819    16822       +3     
  Partials     6714     6714              

see 22 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator Author

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@jakecastelli
Copy link
Member

jakecastelli commented Aug 15, 2024

There is a bit of situation on the current main (tests which rely on the Fast API would fail) PR 54391 is currently being fast tracked to fix it. Therefore the current CI run (which will rebase on main) would fail consistently.
Once 54391 lands, we can restart the CI for this PR (just for the information).

@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@marco-ippolito
Copy link
Member

marco-ippolito commented Aug 16, 2024

@nodejs/build

08:00:27 not ok 3851 pummel/test-fs-readfile-tostring-fail
08:00:27   ---
08:00:27   duration_ms: 224.97000
08:00:27   severity: fail
08:00:27   exitcode: 7
08:00:27   stack: |-
08:00:27     /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/pummel/test-fs-readfile-tostring-fail.js:77
08:00:27       throw err;
08:00:27       ^
08:00:27     
08:00:27     AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ENOSPC: no space left on device, write

@nodejs-github-bot
Copy link
Collaborator Author

@RedYetiDev RedYetiDev added the strip-types Issues or PRs related to strip-types support label Aug 16, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 19, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/54374
✔  Done loading data for nodejs/node/pull/54374
----------------------------------- PR info ------------------------------------
Title      deps: update amaro to 0.1.6 (#54374)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-amaro -> nodejs:main
Labels     lib / src, needs-ci, dependencies, strip-types
Commits    1
 - deps: update amaro to 0.1.6
Committers 1
 - Node.js GitHub Bot <github-bot@iojs.org>
PR-URL: https://github.com/nodejs/node/pull/54374
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54374
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 14 Aug 2024 14:09:38 GMT
   ✔  Approvals: 5
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2238310298
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2238350052
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/54374#pullrequestreview-2239717919
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2240533263
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54374#pullrequestreview-2240538191
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-08-19T08:05:13Z: https://ci.nodejs.org/job/node-test-pull-request/61220/
- Querying data for job/node-test-pull-request/61220/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10452057468

@jakecastelli
Copy link
Member

✘ Last GitHub CI failed

False report maybe? As I didn't see any failure in Github CI though.

@marco-ippolito
Copy link
Member

✘ Last GitHub CI failed

False report maybe? As I didn't see any failure in Github CI though.

yeah looks odd

@jakecastelli
Copy link
Member

jakecastelli commented Aug 19, 2024

I could manually land this if you want, just wanted to double check before I do so. Also would be helpful if the bot can mention in the comment which action was failed 😅

jakecastelli pushed a commit that referenced this pull request Aug 19, 2024
PR-URL: #54374
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@jakecastelli
Copy link
Member

jakecastelli commented Aug 19, 2024

When I use the CLI to land it says:

✘ GitHub CI is still running

instead of Github CI failed

Just for the information.

@jakecastelli
Copy link
Member

Landed in d8d3a6b

@jakecastelli jakecastelli deleted the actions/tools-update-amaro branch August 19, 2024 12:29
RafaelGSS pushed a commit that referenced this pull request Aug 19, 2024
PR-URL: #54374
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 21, 2024
PR-URL: #54374
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants