Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: only use default ALPNProtocols when appropriate #54411

Merged
merged 1 commit into from
Sep 1, 2024
Merged

https: only use default ALPNProtocols when appropriate #54411

merged 1 commit into from
Sep 1, 2024
+17 −4

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Aug 16, 2024

This bug has existed since ALPNCallback support was added in 86ba5be.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run. labels Aug 16, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61195/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61236/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61273/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61630/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61629/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61757/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 71b36b3 into nodejs:main Sep 1, 2024
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 71b36b3

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@mscdex @aduh95
https: only use default ALPNProtocols when appropriate
04ef3e4 
PR-URL: #54411
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@ronag ronag ronag approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mscdex @nodejs-github-bot @ShogunPanda @jasnell @lpinca @pimterry @ronag @Ethan-Arrowood @mertcanaltin @richardlau