Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix discrepancy between .ts and .js #54461

Merged
merged 1 commit into from
Aug 22, 2024
Merged

module: fix discrepancy between .ts and .js #54461

merged 1 commit into from
Aug 22, 2024

Conversation

marco-ippolito
Copy link
Member

Fixes: #54457

This fixes the discrepancy with the .js behavior

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Aug 20, 2024
ShogunPanda
ShogunPanda approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-ippolito marco-ippolito mentioned this pull request Aug 20, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.31%. Comparing base (ef4bdbf) to head (af4f6c9).
Report is 496 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/modules/helpers.js 98.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54461      +/-   ##
==========================================
- Coverage   87.32%   87.31%   -0.01%     
==========================================
  Files         648      648              
  Lines      182383   182389       +6     
  Branches    34991    34987       -4     
==========================================
+ Hits       159260   159262       +2     
- Misses      16384    16390       +6     
+ Partials     6739     6737       -2
Files with missing lines Coverage Δ
lib/internal/modules/esm/get_format.js 88.88% <100.00%> (-1.59%) ⬇️
lib/internal/modules/esm/translators.js 91.49% <100.00%> (-0.56%) ⬇️
lib/internal/modules/helpers.js 97.61% <98.11%> (+0.06%) ⬆️

... and 29 files with indirect coverage changes

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61271/

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61283/

mcollina
mcollina approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjihrig
Copy link
Contributor

cjihrig commented Aug 20, 2024

I can confirm this fixes the issue I was seeing. Thank you for the quick fix.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61310/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61311/

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. strip-types Issues or PRs related to strip-types support labels Aug 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit e35902c into nodejs:main Aug 22, 2024
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e35902c

@RafaelGSS RafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Aug 25, 2024
@RafaelGSS
Copy link
Member

This commit didn't land cleanly on v22.x-staging. Can you create a manual backport?

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Aug 26, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
9612043 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@marco-ippolito marco-ippolito mentioned this pull request Aug 26, 2024
Closed
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Aug 26, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
ba6dd18 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@RedYetiDev RedYetiDev added backport-open-v22.x Indicate that the PR has an open backport and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Aug 26, 2024
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Aug 31, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
62fd7e0 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Sep 2, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
7ad2d1d 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Sep 12, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
63cd6d7 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Sep 16, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
dadd466 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Sep 16, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
bf14500 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Sep 16, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
80c1e92 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Sep 17, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
15d72c1 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Sep 17, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
8c6a2c1 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito added a commit that referenced this pull request Sep 18, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
67ecb10 
PR-URL: #54461
Backport-PR-URL: #54566
Fixes: #54457
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@targos targos added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Oct 5, 2024
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@himself65 himself65 himself65 approved these changes

@legendecas legendecas legendecas approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible discrepancy with --experimental-strip-types