Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 12.9 #54536

Closed
wants to merge 13 commits into from
Closed

deps: update V8 to 12.9 #54536

wants to merge 13 commits into from
+69,524 −18,926

Conversation

targos
Copy link
Member

@targos targos commented Aug 24, 2024 •
edited
Loading

Notable changes:

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 24, 2024
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos
Copy link
Member Author

targos commented Aug 24, 2024

Updated d73e710 to fix the MSVC error.
Opened https://chromium-review.googlesource.com/c/v8/v8/+/5805956 upstream to fix the macOS Clang error.

@targos
Copy link
Member Author

targos commented Aug 24, 2024

@nodejs/platform-aix Can you have a look at https://ci.nodejs.org/job/node-test-commit-aix/53241/nodes=aix72-ppc64/console ?

@RedYetiDev RedYetiDev added the dependencies Pull requests that update a dependency file. label Aug 24, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61508/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6156/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6156/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6156/

@targos
Copy link
Member Author

targos commented Aug 27, 2024

https://ci.nodejs.org/job/node-test-commit-osx/60761/

@targos
Copy link
Member Author

targos commented Aug 27, 2024 •
edited
Loading

https://ci.nodejs.org/job/node-test-commit-windows-fanned/65162/
https://ci.nodejs.org/job/node-compile-windows-debug/23534/

@targos
Copy link
Member Author

targos commented Aug 27, 2024

https://ci.nodejs.org/job/node-test-commit-osx/60768/

@abmusse
Copy link
Contributor

abmusse commented Aug 27, 2024

@nodejs/platform-aix Can you have a look at https://ci.nodejs.org/job/node-test-commit-aix/53241/nodes=aix72-ppc64/console ?

Hello @targos I've opened a CL on v8 to resolve that build issue https://chromium-review.googlesource.com/c/v8/v8/+/5789180

@targos
Copy link
Member Author

targos commented Aug 27, 2024 •
edited
Loading

@nodejs/platform-windows, somehow Windows debug builds are broken. I tried two runs to be sure, but they both ended up in a timeout while building an addon: https://ci.nodejs.org/job/node-compile-windows-debug/23534/nodes=win-vs2022/console

@StefanStojanovic
Copy link
Contributor

@nodejs/platform-windows, somehow Windows debug builds are broken. I tried to runs to be sure, but they both ended up in a timeout while building an addon: https://ci.nodejs.org/job/node-compile-windows-debug/23534/nodes=win-vs2022/console

I'll look into it.

@StefanStojanovic
Copy link
Contributor

So what happens when you run that command (for me it is .\Debug\node.exe deps\npm\node_modules\node-gyp\bin\node-gyp rebuild --directory=test\addons\hello-world --nodedir="E:\work\node") after compiling in debug mode, is that you get this:

image

Clicking Ignore will get you through it, successfully but in CI we cannot do it. I'm not 100% sure, but I think we had this issue with some of the v12.x updates, Will try to find it.

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: update V8 to 12.9.202.18
3bc5332 
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
build: reset embedder string to "-node.0"
d35ef0b 
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
src: update NODE_MODULE_VERSION to 131
9874ba8 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 12.9.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: always define V8_EXPORT_PRIVATE as no-op
a20ae71 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: disable V8 concurrent sparkplug compilation
65c418e 
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: patch V8 to avoid duplicated zlib symbol
b208be2 
PR-URL: nodejs#54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@StefanStojanovic @targos @louwers
deps: patch V8 to support compilation with MSVC
49410c9 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@StefanStojanovic @louwers
deps: fix FP16 bitcasts.h
c5d7d77 
PR-URL: nodejs#53134
Refs: nodejs#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: always define V8_NODISCARD as no-op
7fef745 
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: nodejs#54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: patch V8 to support older Clang versions
049b042 
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: V8: cherry-pick 01a47f3ffff2
ee784f6 
Original commit message:

    [cfi] Add missing 'typename' in SegmentedTable

    Makes the code more consistent and fixes compilation on older Clang
    versions.

    Change-Id: I82abebd500e6651ac5c5b180cd7b49b4f20e8299
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5805956
    Reviewed-by: Samuel Groß <saelo@chromium.org>
    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
    Reviewed-by: Stephen Röttger <sroettger@google.com>
    Cr-Commit-Position: refs/heads/main@{#95809}

Refs: v8/v8@01a47f3
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
deps: V8: cherry-pick 97199f686e2f
4815321 
Original commit message:

    aix: add work around for f16 type

    AIX builds started to fail after this commit https://chromium.googlesource.com/v8/v8.git/+/d057564707d3a5df074b7f49a12a2f1e96638f94.

    Change-Id: I25a5c4ae3b4fe5c27a9fb9e35e2bcd2bbed40351
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5789180
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#95952}

Refs: v8/v8@97199f6
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@abmusse @louwers
tools: add additonal include dirs for V8 on AIX
2d058c1 
On AIX, we now include src/wasm/float16.h from within src/utils/utils.h
and src/wasm/float16.h includes additional header files.

PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RafaelGSS @louwers
2024-10-16, Version 23.0.0 (Current)
b0a38fb 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) nodejs#53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) nodejs#54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) nodejs#47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) nodejs#54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) nodejs#54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) nodejs#54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) nodejs#53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) nodejs#45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) nodejs#53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) nodejs#54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) nodejs#52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) nodejs#52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) nodejs#52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) nodejs#52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) nodejs#55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) nodejs#53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) nodejs#52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) nodejs#54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) nodejs#54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) nodejs#54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) nodejs#54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) nodejs#53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) nodejs#54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) nodejs#49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) nodejs#51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) nodejs#54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) nodejs#54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) nodejs#53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) nodejs#54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) nodejs#54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) nodejs#55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) nodejs#54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) nodejs#54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) nodejs#54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) nodejs#54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) nodejs#53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) nodejs#52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) nodejs#53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) nodejs#54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) nodejs#54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) nodejs#54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) nodejs#54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) nodejs#52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) nodejs#46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) nodejs#52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) nodejs#54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) nodejs#54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) nodejs#54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) nodejs#54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) nodejs#52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) nodejs#52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) nodejs#55020

PR-URL: nodejs#55338
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 3, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
d4d4250 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 3, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
ed6df07 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 4, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
7967f2c 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 4, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
794780e 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 5, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
17c1d51 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 5, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
fc67543 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 6, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
72e4d4a 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 6, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
86f64cf 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 7, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
dc628f8 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 7, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
5fffd95 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 8, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
7c4c528 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 8, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
453c82c 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 9, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
5c2cf0b 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 9, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
971397e 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 10, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
f7b5378 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 10, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
1984a3e 
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @abmusse @StefanStojanovic @richardlau @gengjiawen @aduh95 @marco-ippolito @RedYetiDev