Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v20x backport] deps: update undici to 6.19.8 #54583

Closed
wants to merge 1 commit into from

Conversation

snyamathi
Copy link

@snyamathi snyamathi commented Aug 27, 2024

Update Undici to v6.19.8 using ./tools/dep_updaters/update-undici.sh

This will backport nodejs/undici#3445 to v20 and close the loop on #54274 (comment)

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the notable-change label.

I don't think I'm able to add a label to this PR, but I believe this should be in the CHANGELOG

All tests passed.

Test pass locally when running make -j4 test

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Aug 27, 2024
@mcollina
Copy link
Member

I don't think there is a need for this, the commit should be backportable. However, we have a 2 week grace time after releasing something in the current release before backporting.

The undici update would go in the next release.

@snyamathi snyamathi changed the title deps: update undici to 6.19.8 [v20x backport] deps: update undici to 6.19.8 Aug 27, 2024
@snyamathi
Copy link
Author

Thanks @mcollina I had missed the docs in https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md which explain that process

@snyamathi snyamathi closed this Aug 27, 2024
@snyamathi snyamathi deleted the v20.x branch August 27, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants