-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: throw on invalid encoding in Buffer.from #54586
base: main
Are you sure you want to change the base?
Conversation
2655e59
to
11fe4ff
Compare
@nodejs/buffer |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54586 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 649 649
Lines 182620 182632 +12
Branches 35044 35033 -11
==========================================
- Hits 159484 159481 -3
- Misses 16397 16419 +22
+ Partials 6739 6732 -7
|
01e19f1
to
3f7fe0c
Compare
3f7fe0c
to
9d335ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We should likely fix throughv test. I'll get to it when I can.
PR is currently blocked from landing due to unreliable CI. Likely needs a rebase |
There are relevant non-flaky CI failures that need to be addressed with this PR
Refs: #54533