Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove incorrect entry from changelog #546

Merged
merged 1 commit into from
Jan 22, 2015
Merged

docs: remove incorrect entry from changelog #546

merged 1 commit into from
Jan 22, 2015

Conversation

piscisaureus
Copy link
Contributor

@piscisaureus
Copy link
Contributor Author

Proudly made with the github™ editor

@bnoordhuis
Copy link
Member

You should remove the R=@bnoordhuis from the commit log and maybe mention the revert commit.

@piscisaureus
Copy link
Contributor Author

Dang! now I still don't get to use the merge button.

@piscisaureus
docs: remove incorrect entry from changelog
60402b9 
`url.format()` doesn't take a `path` option; the change that
introduced it was reverted in 913addb.

PR: #546
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
@piscisaureus piscisaureus merged commit 60402b9 into v1.x Jan 22, 2015
@piscisaureus piscisaureus deleted the piscisaureus-patch-1 branch January 22, 2015 01:21
This was referenced Sep 13, 2021
Open
Open
Open
Open
@molllyn1 molllyn1 mentioned this pull request Jun 20, 2023
Open
@karencapiiro karencapiiro mentioned this pull request Jun 20, 2023
Open
@AshdonG AshdonG mentioned this pull request Jun 20, 2023
Open
@Mcculloughj Mcculloughj mentioned this pull request Jun 20, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Jun 20, 2023
Open
@aliscco aliscco mentioned this pull request Jun 20, 2023
Open
@dannybrown13 dannybrown13 mentioned this pull request Jun 20, 2023
Open
@ambai ambai mentioned this pull request Jun 20, 2023
Open
@ZRDK ZRDK mentioned this pull request Jun 20, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Jun 20, 2023
Merged
@s4sc s4sc mentioned this pull request Jun 21, 2023
Open
@olegnn olegnn mentioned this pull request Jun 21, 2023
Open
@KamilPolivka KamilPolivka mentioned this pull request Jun 21, 2023
Open
@lasalasa lasalasa mentioned this pull request Jun 21, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 21, 2023
Open
@akashmitra akashmitra mentioned this pull request Jun 21, 2023
Open
@jhudaz jhudaz mentioned this pull request Jun 21, 2023
Open
@saeedahassan saeedahassan mentioned this pull request Jun 21, 2023
Open
@Mcculloughj Mcculloughj mentioned this pull request Jun 21, 2023
Open
@dannybrown13 dannybrown13 mentioned this pull request Jun 21, 2023
Open
@fishbar fishbar mentioned this pull request Jun 21, 2023
Open
@Qdigital Qdigital mentioned this pull request Jun 21, 2023
Open
@smclinden smclinden mentioned this pull request Jun 21, 2023
Open
@AyushG3112 AyushG3112 mentioned this pull request Jun 22, 2023
Open
@saeedahassan saeedahassan mentioned this pull request Jun 22, 2023
Open
@karencapiiro karencapiiro mentioned this pull request Jun 22, 2023
Open
@baophucct baophucct mentioned this pull request Jun 22, 2023
Open
@BryanLaura BryanLaura mentioned this pull request Jun 22, 2023
Open
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
@adamlaska adamlaska mentioned this pull request Jun 23, 2023
Open
This was referenced Jul 8, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @bnoordhuis