Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: refactoring declaratively with the Array.fromAsync function #54644

Merged
merged 12 commits into from
Sep 27, 2024
Merged

fs: refactoring declaratively with the Array.fromAsync function #54644

merged 12 commits into from
Sep 27, 2024

Commits on Aug 29, 2024

  1. fs: refactoring declaratively with the fromAsync function 

    - Refs: nodejs#51912
    @sonsurim
    sonsurim committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    07d075a View commit details
    Browse the repository at this point in the history

  2. fs: replace global Array to primordials ArrayFromAsync

    @sonsurim
    sonsurim committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e2d8a69 View commit details
    Browse the repository at this point in the history

  3. fix lint error

    @sonsurim
    sonsurim committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dde434c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. benchmark: add fs glob benchmark 

    PR: nodejs#54644 (comment)
    @sonsurim
    sonsurim committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f4025e5 View commit details
    Browse the repository at this point in the history

  2. lint js

    @sonsurim
    sonsurim committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1a9ae15 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. refactor glob benchmark

    @sonsurim
    sonsurim committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    db16e20 View commit details
    Browse the repository at this point in the history

  2. reflected review in glob benchmark

    @sonsurim
    sonsurim committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    43ef1e4 View commit details
    Browse the repository at this point in the history

  3. remove an unused variable

    @sonsurim
    sonsurim committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cb2591a View commit details
    Browse the repository at this point in the history

  4. applied review on glob benchmark

    @sonsurim
    sonsurim committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1ff400e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. fix error where benchmarking type does not match in CI 

    modify config property because boolean cannot be used
    @sonsurim
    sonsurim committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c976446 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. remove parts that affect benchmarking

    @sonsurim
    sonsurim committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7dbb93f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fix too many cases for benchmarking

    @sonsurim
    sonsurim committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    defe492 View commit details
    Browse the repository at this point in the history