build,win: enable clang-cl compilation #54655
Merged
+62
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
added
windows
|
Review requested:
|
nodejs-github-bot
added
i18n-api
StefanStojanovic
force-pushed
the
mefi-clang-cl-compile
branch
from
eb9b801
to
7fa8f54
Compare
StefanStojanovic
added
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
StefanStojanovic
force-pushed
the
mefi-clang-cl-compile
branch
from
7fa8f54
to
e07064d
Compare
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This uses the backported ICU fix needed for compiling with ClangCL. Refs: nodejs#54502 Fixes: nodejs#34201
StefanStojanovic
force-pushed
the
mefi-clang-cl-compile
branch
from
e07064d
to
682f420
Compare
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
targos
approved these changes
Aug 31, 2024
srl295
approved these changes
Sep 6, 2024
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 79a33a7 |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This uses the backported ICU fix needed for compiling with ClangCL. Refs: nodejs#54502 Fixes: nodejs#34201 PR-URL: nodejs#54655 Refs: nodejs#52809 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Steven R Loomis <srl295@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
This uses the backported ICU fix needed for compiling with ClangCL. Refs: nodejs#54502 Fixes: nodejs#34201 PR-URL: nodejs#54655 Refs: nodejs#52809 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Steven R Loomis <srl295@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the previously backported ICU fix needed for compiling with ClangCL.
To make sure all works well I tested these combinations locally (since half of them are not tested in the CI):
Once this lands main branch will have ClangCL compilation enabled on Windows and I'll start working on the CI to have it there as well. After some time I'll add testing those binaries too, and ultimately releases will be built by it).
Refs: #52809
Refs: #54502
Fixes: #34201