meta: remove build-windows.yml
#54662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
CC @nodejs/platform-windows |
jasnell
approved these changes
Aug 31, 2024
StefanStojanovic
approved these changes
Sep 9, 2024
RedYetiDev
force-pushed
the
patch-117
branch
from
ba0862d
to
8084664
Compare
|
Is this good to land? |
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54662 ✔ Done loading data for nodejs/node/pull/54662 ----------------------------------- PR info ------------------------------------ Title meta: remove `build-windows.yml` (#54662) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:patch-117 -> nodejs:main Labels windows, meta Commits 1 - meta: remove `build-windows.yml` Committers 1 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - meta: remove `build-windows.yml` ℹ This PR was created on Fri, 30 Aug 2024 15:55:41 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54662#pullrequestreview-2274122543 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/54662#pullrequestreview-2289493802 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10917631736 |
marco-ippolito
approved these changes
Sep 18, 2024
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ccc7ce0 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
added
the
dont-land-on-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the actions done in
build-windows.ymlare also done incoverage-windows.yml, this means that the separate building of windows in this action is redundant.node/.github/workflows/coverage-windows.yml
Lines 46 to 58 in 2bfc9e4
is the same as
node/.github/workflows/build-windows.yml
Lines 41 to 53 in 2bfc9e4