os: improve tmpdir performance
#54709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
anonrig
force-pushed
the
yagiz/improve-tmpdir-performance
branch
from
402ecf4
to
00cae50
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54709 +/- ##
=======================================
Coverage 87.89% 87.90%
=======================================
Files 651 651
Lines 183364 183375 +11
Branches 35714 35714
=======================================
+ Hits 161171 161194 +23
+ Misses 15465 15459 -6
+ Partials 6728 6722 -6
|
anonrig
force-pushed
the
yagiz/improve-tmpdir-performance
branch
3 times, most recently
from
9e8c1be
to
7b5f0c9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
force-pushed
the
yagiz/improve-tmpdir-performance
branch
2 times, most recently
from
2824662
to
111828d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
cc @nodejs/cpp-reviewers |
jasnell
approved these changes
Sep 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
force-pushed
the
yagiz/improve-tmpdir-performance
branch
from
111828d
to
dfe018e
Compare
trivikr
reviewed
Sep 11, 2024
anonrig
added
the
author ready
trivikr
approved these changes
Sep 11, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1d2603b |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54709 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54709 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54709 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54709 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54709 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the performance of
tmpdir()by moving the implementation to C++ and reducing the communication count between C++ and JS.Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1632/