test: fix test-tls-client-mindhsize for OpenSSL32 #54739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Run on OpenSSL32 - https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/40/ |
richardlau
approved these changes
Sep 3, 2024
lpinca
approved these changes
Sep 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54739 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01%
==========================================
Files 651 651
Lines 183386 183386
Branches 35800 35796 -4
==========================================
- Hits 161504 161491 -13
- Misses 15159 15162 +3
- Partials 6723 6733 +10 |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Sep 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR is currently blocked from landing due to unreliable CI. |
|
@jasnell was going to rebase and try again as I'd seen some PRs mark more tests as flaky. |
mhdawson
force-pushed
the
increase-dh-sizes-for-openssl21
branch
from
104de8a
to
1a1f9ab
Compare
|
Rebased hoping to get more PRs where tests were marked as flaky |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Refs: nodejs#53382 - OpenSSL32 has a minimum dh key size by 2048 by default. - Create larter 3072 dh key needed for testing and adjust tests to use it for builds with OpenSSL32 Signed-off-by: Michael Dawson <midawson@redhat.com>
mhdawson
force-pushed
the
increase-dh-sizes-for-openssl21
branch
from
1a1f9ab
to
f64e597
Compare
|
rebased again as tests that were failing were already marked as flaky. |
github-actions
bot
removed
the
request-ci
mhdawson
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54739 ✔ Done loading data for nodejs/node/pull/54739 ----------------------------------- PR info ------------------------------------ Title test: fix test-tls-client-mindhsize for OpenSSL32 (#54739) Author Michael Dawson <midawson@redhat.com> (@mhdawson) Branch mhdawson:increase-dh-sizes-for-openssl21 -> nodejs:main Labels test, needs-ci Commits 1 - test: fix test-tls-client-mindhsize for OpenSSL32 Committers 1 - Michael Dawson <midawson@redhat.com> PR-URL: https://github.com/nodejs/node/pull/54739 Refs: https://github.com/nodejs/node/issues/53382 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54739 Refs: https://github.com/nodejs/node/issues/53382 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: fix test-tls-client-mindhsize for OpenSSL32 ℹ This PR was created on Tue, 03 Sep 2024 16:32:09 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54739#pullrequestreview-2277959625 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54739#pullrequestreview-2277994160 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54739#pullrequestreview-2283639489 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-11T18:38:03Z: https://ci.nodejs.org/job/node-test-pull-request/62337/ - Querying data for job/node-test-pull-request/62337/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10823337922 |
jasnell
pushed a commit
that referenced
this pull request
Sep 12, 2024
Refs: #53382 - OpenSSL32 has a minimum dh key size by 2048 by default. - Create larter 3072 dh key needed for testing and adjust tests to use it for builds with OpenSSL32 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54739 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in d9ca8b0 |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
Refs: #53382 - OpenSSL32 has a minimum dh key size by 2048 by default. - Create larter 3072 dh key needed for testing and adjust tests to use it for builds with OpenSSL32 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54739 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@james thanks for landing |
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
Refs: #53382 - OpenSSL32 has a minimum dh key size by 2048 by default. - Create larter 3072 dh key needed for testing and adjust tests to use it for builds with OpenSSL32 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54739 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
Refs: #53382 - OpenSSL32 has a minimum dh key size by 2048 by default. - Create larter 3072 dh key needed for testing and adjust tests to use it for builds with OpenSSL32 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54739 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #53382