build: fix conflicting V8 object print flags #54785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
jasnell
approved these changes
Sep 5, 2024
daeyeon
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.build-v8-object-print-240904.Wed.be2b
branch
from
96feceb
to
57a0396
Compare
github-actions
bot
removed
the
request-ci
jasnell
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #54785 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in aff2214 |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #54785 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #54785 Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #54785 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--v8-disable-object-printflag doesn't work due to a conflict with the enabling flag. This patch fixes the bug mentioned in #45458 (comment).Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com