lib: propagate aborted state to dependent signals before firing events #54826

jazelly · 2024-09-07T09:27:25Z

Fixes: #54466
Fixes: #54601

RedYetiDev · 2024-09-07T10:26:05Z

I am not sure if I should update WPT together with this PR, considering @RedYetiDev has drafted a PR to cover this.

I don't think the WPT files need to be updated in this PR, IMO one thing at a time.

But, if you could add a test, that'd be helpful IMO.

lib/internal/abort_controller.js

codecov · 2024-09-07T11:13:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (59c7c55) to head (39b8e88).
Report is 45 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54826   +/-   ##
=======================================
  Coverage   88.03%   88.04%           
=======================================
  Files         652      652           
  Lines      183763   183793   +30     
  Branches    35860    35861    +1     
=======================================
+ Hits       161774   161813   +39     
+ Misses      15237    15232    -5     
+ Partials     6752     6748    -4

Files with missing lines	Coverage Δ
lib/internal/abort_controller.js	`98.03% <100.00%> (+0.12%)`	⬆️

... and 26 files with indirect coverage changes

lib/internal/abort_controller.js

test/parallel/test-abortsignal-any.mjs

RedYetiDev · 2024-09-08T23:42:31Z

Nice!

CC @shaseley (from the spec proposal, authored the original issue)

lib/internal/abort_controller.js

github-actions · 2024-09-09T14:17:44Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

jazelly · 2024-09-19T02:09:13Z

Awesome. I have updated the PR with latest wpt for abort with a separate commit. Also addressed PR comments and redundant test cases in the original commit. PTAL

nodejs-github-bot · 2024-09-19T04:38:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62550/

nodejs-github-bot · 2024-09-19T06:29:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62553/ 💚

PR-URL: #54826 Fixes: #54466 Fixes: #54601 Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2024-09-21T16:07:29Z

Landed in d473606

PR-URL: #54826 Fixes: #54466 Fixes: #54601 Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) #55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) #54159 doc: * add abmusse to collaborators (Abdirahim Musse) #55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) #54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) #54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) #54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) #54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) #54971 src: * mark node `--run` as stable (Yagiz Nizipli) #53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) #55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) #54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) #53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) #55234 PR-URL: TODO

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) #55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) #54159 doc: * add abmusse to collaborators (Abdirahim Musse) #55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) #54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) #54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) #54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) #54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) #54971 src: * mark node `--run` as stable (Yagiz Nizipli) #53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) #55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) #54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) #53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) #55234 PR-URL: #55343

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) #55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) #54159 doc: * add abmusse to collaborators (Abdirahim Musse) #55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) #54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) #54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) #54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) #54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) #54971 src: * mark `node --run` as stable (Yagiz Nizipli) #53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) #55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) #54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) #53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) #55234 PR-URL: #55343

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) #55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) #54159 doc: * add abmusse to collaborators (Abdirahim Musse) #55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) #54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) #54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) #54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) #54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) #54971 process: * (SEMVER-MINOR) add `process.features.require_module` (Joyee Cheung) #55241 src: * mark `node --run` as stable (Yagiz Nizipli) #53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) #55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) #54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) #53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) #55234 PR-URL: #55343

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) #55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) #54159 doc: * add abmusse to collaborators (Abdirahim Musse) #55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) #54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) #54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) #54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) #54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) #54971 process: * (SEMVER-MINOR) add `process.features.require_module` (Joyee Cheung) #55241 * (SEMVER-MINOR) add `process.features.typescript` (Aviv Keller) #54295 src: * mark `node --run` as stable (Yagiz Nizipli) #53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) #55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) #54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) #53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) #55234 PR-URL: #55343

PR-URL: nodejs#54826 Fixes: nodejs#54466 Fixes: nodejs#54601 Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) nodejs#55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) nodejs#54159 doc: * add abmusse to collaborators (Abdirahim Musse) nodejs#55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) nodejs#54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) nodejs#54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) nodejs#54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) nodejs#54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) nodejs#54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) nodejs#54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) nodejs#54971 process: * (SEMVER-MINOR) add `process.features.require_module` (Joyee Cheung) nodejs#55241 * (SEMVER-MINOR) add `process.features.typescript` (Aviv Keller) nodejs#54295 src: * mark `node --run` as stable (Yagiz Nizipli) nodejs#53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) nodejs#55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) nodejs#54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) nodejs#53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) nodejs#55234 PR-URL: nodejs#55343

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 7, 2024

This comment was marked as resolved.

Sign in to view

jazelly changed the title ~~lib: propogate aborted state to dependent signals before firing events~~ lib: propagate aborted state to dependent signals before firing events Sep 7, 2024

jazelly force-pushed the fix-54466 branch 4 times, most recently from a40318c to 21864d2 Compare September 7, 2024 09:58

RedYetiDev added abortcontroller Issues and PRs related to the AbortController API web-standards Issues and PRs related to Web APIs labels Sep 7, 2024

This comment was marked as outdated.

Sign in to view

jazelly marked this pull request as draft September 7, 2024 10:46

RedYetiDev reviewed Sep 7, 2024

View reviewed changes

lib/internal/abort_controller.js Show resolved Hide resolved

RedYetiDev reviewed Sep 7, 2024

View reviewed changes

lib/internal/abort_controller.js Show resolved Hide resolved

jazelly force-pushed the fix-54466 branch from 21864d2 to f87de39 Compare September 8, 2024 23:23

jazelly marked this pull request as ready for review September 8, 2024 23:24

jazelly force-pushed the fix-54466 branch from f87de39 to d1719ac Compare September 8, 2024 23:30

RedYetiDev reviewed Sep 8, 2024

View reviewed changes

lib/internal/abort_controller.js Outdated Show resolved Hide resolved

RedYetiDev reviewed Sep 8, 2024

View reviewed changes

test/parallel/test-abortsignal-any.mjs Outdated Show resolved Hide resolved

jazelly force-pushed the fix-54466 branch from d1719ac to 659477e Compare September 8, 2024 23:38

jazelly force-pushed the fix-54466 branch from 659477e to 97a286b Compare September 8, 2024 23:43

jasnell reviewed Sep 9, 2024

View reviewed changes

lib/internal/abort_controller.js Outdated Show resolved Hide resolved

jasnell reviewed Sep 9, 2024

View reviewed changes

lib/internal/abort_controller.js Outdated Show resolved Hide resolved

jasnell added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 9, 2024

jasnell approved these changes Sep 9, 2024

View reviewed changes

jazelly force-pushed the fix-54466 branch from 97a286b to be7dd22 Compare September 10, 2024 06:03

RedYetiDev added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2024

jazelly force-pushed the fix-54466 branch from e9be358 to 459af51 Compare September 19, 2024 01:45

jakecastelli added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Sep 19, 2024

jazelly added 2 commits September 19, 2024 11:18

lib: propagate aborted state to dependent signals before firing events

147e101

test: downstream wpt for abort

39b8e88

jazelly force-pushed the fix-54466 branch from 459af51 to 39b8e88 Compare September 19, 2024 02:00

jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

jasnell approved these changes Sep 21, 2024

View reviewed changes

jasnell pushed a commit that referenced this pull request Sep 21, 2024

lib: propagate aborted state to dependent signals before firing events

d473606

PR-URL: #54826 Fixes: #54466 Fixes: #54601 Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell closed this Sep 21, 2024

targos pushed a commit that referenced this pull request Oct 4, 2024

lib: propagate aborted state to dependent signals before firing events

f7c3b03

PR-URL: #54826 Fixes: #54466 Fixes: #54601 Reviewed-By: James M Snell <jasnell@gmail.com>

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

RafaelGSS mentioned this pull request Oct 11, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024

lib: propagate aborted state to dependent signals before firing events

63e37d6

PR-URL: nodejs#54826 Fixes: nodejs#54466 Fixes: nodejs#54601 Reviewed-By: James M Snell <jasnell@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: propagate aborted state to dependent signals before firing events #54826

lib: propagate aborted state to dependent signals before firing events #54826

jazelly commented Sep 7, 2024 •

edited

Loading

This comment was marked as resolved.

RedYetiDev commented Sep 7, 2024 •

edited

Loading

This comment was marked as outdated.

codecov bot commented Sep 7, 2024 •

edited

Loading

RedYetiDev commented Sep 8, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024

jazelly commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024 •

edited by jakecastelli

Loading

jasnell commented Sep 21, 2024

lib: propagate aborted state to dependent signals before firing events #54826

lib: propagate aborted state to dependent signals before firing events #54826

Conversation

jazelly commented Sep 7, 2024 • edited Loading

This comment was marked as resolved.

RedYetiDev commented Sep 7, 2024 • edited Loading

This comment was marked as outdated.

codecov bot commented Sep 7, 2024 • edited Loading

Codecov Report

RedYetiDev commented Sep 8, 2024 • edited Loading

github-actions bot commented Sep 9, 2024

jazelly commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024 • edited by jakecastelli Loading

jasnell commented Sep 21, 2024

jazelly commented Sep 7, 2024 •

edited

Loading

RedYetiDev commented Sep 7, 2024 •

edited

Loading

codecov bot commented Sep 7, 2024 •

edited

Loading

RedYetiDev commented Sep 8, 2024 •

edited

Loading

nodejs-github-bot commented Sep 19, 2024 •

edited by jakecastelli

Loading