lib: remove unnecessary async #54829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jason Zhang <xzha4350@gmail.com>
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54829 +/- ##
==========================================
- Coverage 87.62% 87.61% -0.01%
==========================================
Files 650 651 +1
Lines 182983 183343 +360
Branches 35406 35445 +39
==========================================
+ Hits 160336 160639 +303
- Misses 15917 15959 +42
- Partials 6730 6745 +15
|
jasnell
approved these changes
Sep 7, 2024
lpinca
approved these changes
Sep 12, 2024
github-actions
bot
removed
the
request-ci
jakecastelli
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 55f70ee |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
Co-authored-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #54829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
Co-authored-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #54829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #54829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #54829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with Jason @jazelly on another web streams issue and when we go through the code in
adapterswe found thisasyncis likely unnecessary.