fs: translate error code properly in cpSync #54906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jakecastelli
added
request-ci
jazelly
force-pushed
the
translate-fs-errors
branch
from
be5dfdd
to
4f40f36
Compare
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Sep 12, 2024
|
Nice. Thank you! |
anonrig
added
the
author ready
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54906 +/- ##
==========================================
- Coverage 88.05% 88.05% -0.01%
==========================================
Files 651 651
Lines 183405 183412 +7
Branches 35822 35825 +3
==========================================
- Hits 161499 161497 -2
- Misses 15159 15160 +1
- Partials 6747 6755 +8
|
jazelly
force-pushed
the
translate-fs-errors
branch
2 times, most recently
from
c94e771
to
b49dafb
Compare
lpinca
approved these changes
Sep 13, 2024
UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing. Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
jazelly
force-pushed
the
translate-fs-errors
branch
from
b49dafb
to
090dce2
Compare
lpinca
approved these changes
Sep 13, 2024
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Sep 13, 2024
jakecastelli
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c1afd2c |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing. Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com> PR-URL: #54906 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing. Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com> PR-URL: #54906 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing. Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com> PR-URL: #54906 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing. Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com> PR-URL: #54906 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing. Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com> PR-URL: nodejs#54906 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing.
Refs: #53614 (comment)