Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: report unfinished TLA in ambiguous modules #54980

Merged
merged 2 commits into from
Sep 19, 2024
+14 −1
Merged

module: report unfinished TLA in ambiguous modules #54980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5930f8e
module: report unfinished TLA in ambiguous modules
aduh95 Sep 17, 2024
2ee5df9
fixup! module: report unfinished TLA in ambiguous modules
aduh95 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
module: report unfinished TLA in ambiguous modules
@aduh95
aduh95 committed Sep 17, 2024
commit 5930f8ec3db260b4b7c0b237d52377a7f2e2a2b1
2 changes: 1 addition & 1 deletion lib/internal/modules/cjs/loader.js
View file
Original file line number Diff line number Diff line change
@@ -1381,7 +1381,7 @@ function loadESMFromCJS(mod, filename) {
if (isMain) {
require('internal/modules/run_main').runEntryPointWithESMLoader((cascadedLoader) => {
const mainURL = pathToFileURL(filename).href;
cascadedLoader.import(mainURL, undefined, { __proto__: null }, true);
return cascadedLoader.import(mainURL, undefined, { __proto__: null }, true);
});
// ESM won't be accessible via process.mainModule.
setOwnProperty(process, 'mainModule', undefined);
12 changes: 12 additions & 0 deletions test/es-module/test-esm-detect-ambiguous.mjs
View file
Original file line number Diff line number Diff line change
@@ -252,6 +252,18 @@
strictEqual(signal, null);
});

it('reports unfinished top-level `await`', async () => {
const { stdout, stderr, code, signal } = await spawnPromisified(process.execPath, [
'--no-warnings',
fixtures.path('es-modules/tla/unresolved.js')

Check failure on line 258 in test/es-module/test-esm-detect-ambiguous.mjs

GitHub Actions / lint-js-and-md 

Missing trailing comma
]);

strictEqual(stderr, '');
strictEqual(stdout, '');
strictEqual(code, 13);
strictEqual(signal, null);
});

it('permits top-level `await` above import/export syntax', async () => {
const { stdout, stderr, code, signal } = await spawnPromisified(process.execPath, [
'--eval',