src: replace splitstring with built-in

[anonrig]

Replaces SplitString function with built-in implementation available for C++20

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (3ac5b49) to head (d9790fe).
Report is 101 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_options.cc	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54990   +/-   ##
=======================================
  Coverage   88.07%   88.08%           
=======================================
  Files         652      652           
  Lines      183653   183705   +52     
  Branches    35856    35865    +9     
=======================================
+ Hits       161753   161809   +56     
+ Misses      15146    15142    -4     
  Partials     6754     6754           

Files with missing lines	Coverage Δ
src/node_v8_platform-inl.h	87.17% <100.00%> (+0.16%)	⬆️
src/util.cc	87.41% <ø> (+0.07%)	⬆️
src/util.h	89.91% <ø> (ø)
src/node_options.cc	88.08% <75.00%> (+0.01%)	⬆️

... and 41 files with indirect coverage changes

[anonrig]

cc @nodejs/cpp-reviewers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62634/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62658/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62667/

[anonrig]

cc @nodejs/platform-smartos it seems smartos doesn't implement C++20 correctly.

[lemire]

@anonrig The log indicates that GCC 10 is used (which is the default in SmartOS as far as I can tell).

However, Node requires g++ 12.2.0 or clang++ 8.0.0 or better.

And, indeed, look carefully at the build log...

07:30:41 WARNING: C++ compiler (CXX=ccache g++, 10.3.0) too old, need g++ 12.2.0 or clang++ 8.0.0

It is surprising that this PR hits this issue.

[richardlau]

SmartOS is in the process of being migrated to newer SmartOS as part of the migration of non-ARM servers from Equinix Metal: nodejs/build#3731

nodejs/build#3806 tracks gcc 12 deployment -- SmartOS is the remaining platform and the expectation is that moving to SmartOS 23 should resolve that.

[anonrig]

@richardlau did the smartos migration complete? is there any blocker for this pull-request atm?

[richardlau]

@richardlau did the smartos migration complete? is there any blocker for this pull-request atm?

@anonrig I'm not actively involved in the smartos migration, but I don't believe it's complete yet.