fs: check subdir correctly in cpSync #55033

jazelly · 2024-09-20T21:03:08Z

test/parallel/test-fs-cp.mjs

jazelly · 2024-09-20T21:50:21Z

This probably will have merge conflicts with #54653. I'd like the other one to land first as this one is easier to rebase, re-review and re-approve, if that sounds good : )

RedYetiDev · 2024-09-20T22:06:41Z

Per the comment above, I've added blocked, however, feel free to adjust.

codecov · 2024-09-20T23:54:11Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (cfe58cf) to head (9358d9e).
Report is 422 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_file.cc	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55033   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         652      652           
  Lines      183912   183916    +4     
  Branches    35865    35862    -3     
=======================================
+ Hits       162272   162283   +11     
+ Misses      14915    14910    -5     
+ Partials     6725     6723    -2

Files with missing lines	Coverage Δ
src/node_file.cc	`77.06% <80.00%> (-0.01%)`	⬇️

... and 33 files with indirect coverage changes

jakecastelli · 2024-09-21T02:10:29Z

cc. @nodejs/fs @anonrig @aduh95 (surprised that both of you aren't in the fs team 😄)

jakecastelli

The other PR has landed and indeed there are merge conflicts now.

jazelly · 2024-09-22T11:44:18Z

Conflicts resolved ^ PTAL

nodejs-github-bot · 2024-09-23T09:40:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62685/

nodejs-github-bot · 2024-09-24T21:06:41Z

Commit Queue failed

- Loading data for nodejs/node/pull/55033
✔  Done loading data for nodejs/node/pull/55033
----------------------------------- PR info ------------------------------------
Title      fs: check subdir correctly in cpSync (#55033)
Author     Jason Zhang <xzha4350@gmail.com> (@jazelly)
Branch     jazelly:fix-54285 -> nodejs:main
Labels     c++, fs, author ready, needs-ci
Commits    1
 - fs: check subdir correctly in cpSync
Committers 1
 - Jason Zhang <xzha4350@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/55033
Fixes: https://github.com/nodejs/node/issues/54285
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55033
Fixes: https://github.com/nodejs/node/issues/54285
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 20 Sep 2024 21:03:08 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55033#pullrequestreview-2321643883
   ✘  This PR needs to wait 71 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-23T09:40:40Z: https://ci.nodejs.org/job/node-test-pull-request/62685/
- Querying data for job/node-test-pull-request/62685/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11021901134

nodejs-github-bot · 2024-09-27T22:51:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62808/

nodejs-github-bot · 2024-09-28T10:34:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62820/

nodejs-github-bot · 2024-09-28T13:50:55Z

Landed in 7fe5bcd

PR-URL: #55033 Fixes: #54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: nodejs#55033 Fixes: nodejs#54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 20, 2024

jazelly changed the title ~~fs: check subdir correct in cpSync~~ fs: check subdir correctly in cpSync Sep 20, 2024

RedYetiDev reviewed Sep 20, 2024

View reviewed changes

test/parallel/test-fs-cp.mjs Outdated Show resolved Hide resolved

jazelly force-pushed the fix-54285 branch from 6c83503 to e6c9d3f Compare September 20, 2024 21:40

jazelly marked this pull request as ready for review September 20, 2024 21:43

jazelly force-pushed the fix-54285 branch from e6c9d3f to 1b7ea01 Compare September 20, 2024 21:45

jazelly force-pushed the fix-54285 branch from 1b7ea01 to 538913c Compare September 20, 2024 21:51

jazelly marked this pull request as draft September 20, 2024 21:57

RedYetiDev added the blocked PRs that are blocked by other issues or PRs. label Sep 20, 2024

jazelly force-pushed the fix-54285 branch from 538913c to aaccbff Compare September 20, 2024 22:05

jazelly marked this pull request as ready for review September 20, 2024 22:05

jazelly force-pushed the fix-54285 branch from aaccbff to b654965 Compare September 20, 2024 22:08

jakecastelli reviewed Sep 22, 2024

View reviewed changes

jakecastelli removed the blocked PRs that are blocked by other issues or PRs. label Sep 22, 2024

fs: check subdir correctly in cpSync

9358d9e

jazelly force-pushed the fix-54285 branch from b654965 to 9358d9e Compare September 22, 2024 04:13

aduh95 approved these changes Sep 23, 2024

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 23, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 24, 2024

joyeecheung approved these changes Sep 27, 2024

View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2024

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 28, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024

nodejs-github-bot merged commit 7fe5bcd into nodejs:main Sep 28, 2024
69 checks passed

targos pushed a commit that referenced this pull request Oct 4, 2024

fs: check subdir correctly in cpSync

a43ce87

PR-URL: #55033 Fixes: #54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos pushed a commit that referenced this pull request Oct 4, 2024

fs: check subdir correctly in cpSync

1c94725

PR-URL: #55033 Fixes: #54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024

fs: check subdir correctly in cpSync

8279f0c

PR-URL: nodejs#55033 Fixes: nodejs#54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024

fs: check subdir correctly in cpSync

af617b0

PR-URL: nodejs#55033 Fixes: nodejs#54285 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: check subdir correctly in cpSync #55033

fs: check subdir correctly in cpSync #55033

jazelly commented Sep 20, 2024

jazelly commented Sep 20, 2024 •

edited

Loading

RedYetiDev commented Sep 20, 2024

codecov bot commented Sep 20, 2024 •

edited

Loading

jakecastelli commented Sep 21, 2024

jakecastelli left a comment

jazelly commented Sep 22, 2024

nodejs-github-bot commented Sep 23, 2024

nodejs-github-bot commented Sep 24, 2024

nodejs-github-bot commented Sep 27, 2024

nodejs-github-bot commented Sep 28, 2024

nodejs-github-bot commented Sep 28, 2024

fs: check subdir correctly in cpSync #55033

fs: check subdir correctly in cpSync #55033

Conversation

jazelly commented Sep 20, 2024

jazelly commented Sep 20, 2024 • edited Loading

RedYetiDev commented Sep 20, 2024

codecov bot commented Sep 20, 2024 • edited Loading

Codecov Report

jakecastelli commented Sep 21, 2024

jakecastelli left a comment

Choose a reason for hiding this comment

jazelly commented Sep 22, 2024

nodejs-github-bot commented Sep 23, 2024

nodejs-github-bot commented Sep 24, 2024

nodejs-github-bot commented Sep 27, 2024

nodejs-github-bot commented Sep 28, 2024

nodejs-github-bot commented Sep 28, 2024

jazelly commented Sep 20, 2024 •

edited

Loading

codecov bot commented Sep 20, 2024 •

edited

Loading