Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: check subdir correctly in cpSync #55033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jazelly
Copy link
Contributor

@jazelly jazelly commented Sep 20, 2024

Fixes: #54285

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 20, 2024
@jazelly jazelly changed the title fs: check subdir correct in cpSync fs: check subdir correctly in cpSync Sep 20, 2024
@jazelly
Copy link
Contributor Author

jazelly commented Sep 20, 2024

This probably will have merge conflicts with #54653. I'd like the other one to land first as this one is easier to rebase, re-review and re-approve, if that sounds good : )

@jazelly jazelly marked this pull request as draft September 20, 2024 21:57
@RedYetiDev RedYetiDev added the blocked PRs that are blocked by other issues or PRs. label Sep 20, 2024
@jazelly jazelly marked this pull request as ready for review September 20, 2024 22:05
@RedYetiDev
Copy link
Member

Per the comment above, I've added blocked, however, feel free to adjust.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (8b8fc53) to head (b654965).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55033   +/-   ##
=======================================
  Coverage   88.23%   88.24%           
=======================================
  Files         652      652           
  Lines      183855   183859    +4     
  Branches    35856    35852    -4     
=======================================
+ Hits       162227   162238   +11     
+ Misses      14909    14903    -6     
+ Partials     6719     6718    -1     
Files with missing lines Coverage Δ
src/node_file.cc 77.05% <80.00%> (-0.05%) ⬇️

... and 29 files with indirect coverage changes

@jakecastelli
Copy link
Contributor

cc. @nodejs/fs @anonrig @aduh95 (surprised that both of you aren't in the fs team 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.cpSync fails when copying to a directory with a name starting with the source directory name
4 participants