Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: notify via slack when review-wanted #55102

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/notify-on-review-wanted.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Notify on Review Wanted
on:
issues:
types: [labeled]
Comment on lines +3 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense to trigger that on issues.

Suggested change
issues:
types: [labeled]

Although, shouldn't we instead add a job to .github/workflows/comment-labeled.yml instead of creating a new workflow?

pull_request_target:
types: [labeled]

permissions:
contents: read
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved

jobs:
notifyOnReviewWanted:
name: Notify on Review Wanted
if: github.repository == 'nodejs/node'
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- name: Determine PR or Issue
id: check_pr_or_issue
run: |
if [[ -n "${{ github.event.pull_request.number }}" ]]; then
echo "::set-output name=type::pull_request"
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
echo "::set-output name=number::${{ github.event.pull_request.number }}"
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
else
echo "::set-output name=type::issue"
echo "::set-output name=number::${{ github.event.issue.number }}"
fi

- name: Slack Notification
uses: rtCamp/action-slack-notify@4e5fb42d249be6a45a298f3c9543b111b02f7907 # 2.3.0
env:
SLACK_COLOR: '#DE512A'
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: ${{ github.actor }} asks for review on ${{ steps.check_pr_or_issue.outputs.type == 'pull_request' && 'PR' || 'Issue' }} #${{ steps.check_pr_or_issue.outputs.number }}

Check warning on line 33 in .github/workflows/notify-on-review-wanted.yml

View workflow job for this annotation

GitHub Actions / lint-yaml

33:144 [comments] too few spaces before comment

Check warning on line 33 in .github/workflows/notify-on-review-wanted.yml

View workflow job for this annotation

GitHub Actions / lint-yaml

33:145 [comments] missing starting space in comment
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
SLACK_MESSAGE: |
This ${{ steps.check_pr_or_issue.outputs.type == 'pull_request' && 'PR' || 'Issue' }} requires review from Node.js maintainers <https://github.com/${{ github.repository }}/pull/${{ steps.check_pr_or_issue.outputs.number }}|#${{ steps.check_pr_or_issue.outputs.number }}> by <https://github.com/${{ github.actor }}|${{ github.actor }}>
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
SLACK_USERNAME: nodejs-bot
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
Loading