Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add resource to internal module stat test #55157

Closed
wants to merge 2 commits into from
Closed

test: add resource to internal module stat test #55157

wants to merge 2 commits into from

Conversation

RafaelGSS
Copy link
Member

This was missing from #51344

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2024 •
edited by RafaelGSS
Loading

Review requested:

  • @nodejs/security-wg

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (3ac5b49) to head (ee3f3ac).
Report is 175 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55157      +/-   ##
==========================================
+ Coverage   88.07%   88.24%   +0.17%     
==========================================
  Files         652      651       -1     
  Lines      183653   183855     +202     
  Branches    35856    35825      -31     
==========================================
+ Hits       161753   162249     +496     
+ Misses      15146    14921     -225     
+ Partials     6754     6685      -69

see 152 files with indirect coverage changes

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62833/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62846/

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62857/

@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 2, 2024
RafaelGSS added a commit that referenced this pull request Oct 7, 2024
@RafaelGSS
test: add resource to internal module stat test
6c92c13 
PR-URL: #55157
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS
Copy link
Member Author

Landed in 6c92c13

@RafaelGSS RafaelGSS closed this Oct 7, 2024
aduh95 pushed a commit that referenced this pull request Oct 9, 2024
@RafaelGSS @aduh95
test: add resource to internal module stat test
1b1104e 
PR-URL: #55157
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RafaelGSS @louwers
test: add resource to internal module stat test
2742e52 
PR-URL: nodejs#55157
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@RafaelGSS @tpoisseau
test: add resource to internal module stat test
c0a19aa 
PR-URL: nodejs#55157
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RafaelGSS @nodejs-github-bot @anonrig @marco-ippolito