-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update gyp-next to 0.18.2 #55160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
gyp
Issues and PRs related to the GYP tool and .gyp build files
tools
Issues and PRs related to the tools directory.
labels
Sep 29, 2024
Review requested:
|
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
labels
Sep 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55160 +/- ##
=======================================
Coverage 88.24% 88.24%
=======================================
Files 651 651
Lines 183836 183836
Branches 35827 35829 +2
=======================================
+ Hits 162218 162224 +6
- Misses 14916 14922 +6
+ Partials 6702 6690 -12 |
lpinca
approved these changes
Sep 29, 2024
legendecas
approved these changes
Oct 1, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 1, 2024
gengjiawen
approved these changes
Oct 3, 2024
legendecas
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 8, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 8, 2024
Landed in 8dbca2d |
aduh95
pushed a commit
that referenced
this pull request
Oct 9, 2024
PR-URL: #55160 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55160 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
marco-ippolito
added
the
backport-requested-v20.x
PRs awaiting manual backport to the v20.x-staging branch.
label
Nov 16, 2024
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55160 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-requested-v20.x
PRs awaiting manual backport to the v20.x-staging branch.
build
Issues and PRs related to build files or the CI.
gyp
Issues and PRs related to the GYP tool and .gyp build files
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of gyp-next to 0.18.2.