Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update gyp-next to 0.18.2 #55160

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of gyp-next to 0.18.2.

@nodejs-github-bot nodejs-github-bot added gyp Issues and PRs related to the GYP tool and .gyp build files tools Issues and PRs related to the tools directory. labels Sep 29, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (e225f00) to head (322fc11).
Report is 335 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55160   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files         651      651           
  Lines      183836   183836           
  Branches    35827    35829    +2     
=======================================
+ Hits       162218   162224    +6     
- Misses      14916    14922    +6     
+ Partials     6702     6690   -12     

see 30 files with indirect coverage changes

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8dbca2d into main Oct 8, 2024
76 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 8dbca2d

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-gyp-next branch October 8, 2024 03:15
aduh95 pushed a commit that referenced this pull request Oct 9, 2024
PR-URL: #55160
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55160
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@marco-ippolito marco-ippolito added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55160
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants