Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix not valid json in coverage #55179

Merged
merged 1 commit into from
Sep 30, 2024
Merged

build: fix not valid json in coverage #55179

merged 1 commit into from
Sep 30, 2024

Conversation

jakecastelli
Copy link
Member

@jakecastelli jakecastelli commented Sep 30, 2024 •
edited by RafaelGSS
Loading

Fixes https://github.com/nodejs/node/actions/runs/11107498508/job/30858220494 and on current main

Unexpected token ']', ..."ps/**",
  ],
  "repo"... is not valid JSON

Refs: #53256 (comment)

@RedYetiDev RedYetiDev added fast-track PRs that do not need to wait for 48 hours to land. coverage Issues and PRs related to native coverage support. labels Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

@RedYetiDev
Copy link
Member

Fast tracking as this is failing on main, and shouldn't require to much conversation about the fix

@richardlau
Copy link
Member

The coverage workflows don't appear to be running for this PR -- probably due to the paths setting. We should update that to include this file as it has obviously affected the workflows.

@shrujalshah28 shrujalshah28 mentioned this pull request Sep 30, 2024
Closed
@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 30, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 28ffa4b into nodejs:main Sep 30, 2024
34 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 28ffa4b

@iwuliz iwuliz mentioned this pull request Oct 1, 2024
Merged
targos pushed a commit that referenced this pull request Oct 5, 2024
@jakecastelli @targos
build: fix not valid json in coverage
0d93b1e 
PR-URL: #55179
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@jakecastelli @louwers
build: fix not valid json in coverage
85d2760 
PR-URL: nodejs#55179
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. coverage Issues and PRs related to native coverage support. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakecastelli @RedYetiDev @richardlau @nodejs-github-bot @RafaelGSS @aduh95