module: use kNodeModulesRE to detect node_modules

[joyeecheung]

This is faster and more consistent with other places using the regular expression to detect node_modules.

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62898/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (d24c731) to head (676184d).
Report is 365 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55243      +/-   ##
==========================================
- Coverage   88.39%   88.39%   -0.01%     
==========================================
  Files         652      652              
  Lines      186568   186563       -5     
  Branches    36047    36043       -4     
==========================================
- Hits       164924   164916       -8     
+ Misses      14915    14912       -3     
- Partials     6729     6735       +6     

Files with missing lines	Coverage Δ
lib/internal/modules/cjs/loader.js	97.42% <100.00%> (ø)
lib/internal/modules/esm/load.js	92.24% <100.00%> (ø)
lib/internal/modules/helpers.js	99.01% <ø> (-0.02%)	⬇️
lib/internal/util.js	96.87% <100.00%> (+0.01%)	⬆️

... and 25 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[anonrig]

Can you share some benchmarks?

[joyeecheung]

Personally I am not a fan of adding microbenchmarks of internals into the benchmark suite, so I'll just share some local benchmark results:

const path = require('path');
const fs = require('fs');

const kNodeModulesRE = /^(?:.*)[\\/]node_modules[\\/]/;

function isUnderNodeModules(filename) {
  return filename && kNodeModulesRE.exec(filename) !== null;
}

function isUnderNodeModulesByPath(filename) {
  const resolvedPath = path.resolve(filename);
  const normalizedPath = path.normalize(resolvedPath);
  const splitPath = normalizedPath.split(path.sep);
  return splitPath.includes('node_modules');
}

const check = process.env.TYPE === 'PATH' ? isUnderNodeModulesByPath : isUnderNodeModules;
const files = fs.globSync('**/*.js');
const results = [];

console.time(files.length);
for (let i = 0; i < files.length; ++i) {
  results.push(check(files[i]));
}
console.timeEnd(results.length);

❯ NODE_NO_WARNINGS=1 TYPE=REGEXP out/Release/node bench.js
23559: 4.73ms
❯ NODE_NO_WARNINGS=1 TYPE=PATH out/Release/node bench.js
23559: 34.513ms

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62907/

[marco-ippolito]

LGTM I remember I created that function as a workaround, thanks for handling it properly

[nodejs-github-bot]

Landed in bdd590b