src: implement IsInsideNodeModules() in C++ #55286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
|
The performance doesn't really matter all that much for const array = [];
console.time('new Buffer');
for (let i = 0; i < 10000; ++i) {
array.push(new Buffer(10));
}
console.timeEnd('new Buffer'); |
joyeecheung
force-pushed
the
node-modules-check
branch
from
5273982
to
d0d6f97
Compare
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/11196042300 |
|
Interesting |
anonrig
approved these changes
Oct 6, 2024
| @@ -292,10 +292,47 @@ static void GetCallSite(const FunctionCallbackInfo<Value>& args) { | |||
|
|
|||
| callsite_objects.push_back(obj); | |||
| } | |||
| } | |||
|
|
|||
| static void IsInsideNodeModules(const FunctionCallbackInfo<Value>& args) { | |||
There was a problem hiding this comment.
We can add V8 fast api to this to speed things up.
There was a problem hiding this comment.
I don't know if it's safe to iterate over the stack in the fast calls - probably safer to leave it to a follow up to avoid regressions if it's not and isn't reproducible from the tests.
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
This previously compiles a script and run it in a new context to avoid global pollution, which is more complex than necessary and can be too slow for it to be reused in other cases. The new implementation just checks the frames in C++ which is safe from global pollution, faster and simpler. The previous implementation also had a bug when the call site is in a ESM, because ESM have URLs as their script names, which don't start with '/' or '\' and will be skipped. The new implementation removes the skipping to fix it for ESM.
joyeecheung
force-pushed
the
node-modules-check
branch
from
d0d6f97
to
eb8eba8
Compare
|
Rebased to resolve the merge conflict which caused the CI failures. PTAL again @anonrig |
|
Linter is complaining @joyeecheung |
anonrig
approved these changes
Oct 7, 2024
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
8 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55286 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 652 652
Lines 186756 186759 +3
Branches 36100 36106 +6
==========================================
- Hits 165126 165109 -17
- Misses 14906 14915 +9
- Partials 6724 6735 +11
|
anonrig
approved these changes
Oct 7, 2024
legendecas
approved these changes
Oct 8, 2024
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1435338 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This previously compiles a script and run it in a new context to avoid global pollution, which is more complex than necessary and can be too slow for it to be reused in other cases. The new implementation just checks the frames in C++ which is safe from global pollution, faster and simpler. The previous implementation also had a bug when the call site is in a ESM, because ESM have URLs as their script names, which don't start with '/' or '\' and will be skipped. The new implementation removes the skipping to fix it for ESM. PR-URL: nodejs#55286 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously compiles a script and run it in a new context to avoid global pollution, which is more complex than necessary and can be too slow for it to be reused in other cases. The new implementation just checks the frames in C++ which is safe from global pollution, faster and simpler.
The previous implementation also had a bug when the call site is in a ESM, because ESM have URLs as their script names, which don't start with '/' or '\' and will be skipped. The new implementation removes the skipping to fix it for ESM.