Revert "test_runner: ignore unmapped lines for coverage"

[RedYetiDev]

Reverts #55228

This reverts a PR that was intended to fix #54753, however, the tests that it added where not accurate, and it actually does not pass the tests that it should pass.

Once this lands, I'll open a follow up with tests for this behavior so that this doesn't happen again.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[cjihrig]

Please drop the second commit. Just the revert.

[geeksilva97]

#55228 (comment) any consideration on this comment?

Also, would you point which tests are failing, @RedYetiDev ? (if this info is public)

[RedYetiDev]

Also, would you point which tests are failing, @RedYetiDev ? (if this info is public)

(From @cjihrig)

If source maps are enabled, coverage should be based on the original source. If a function in the original source is uncovered, it should be reported as uncovered.

I'm assuming the function is not mapped because of some dead code elimination or similar optimization during transpilation. That doesn't change the fact that it exists in the original source and is never executed.

You can see this if you compare --enable-source-maps to running without the flag. While the output should be same, after your PR, there are pretty distinct differences.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63016/

[RedYetiDev]

Fast tracking for the upcoming proposal(s).

[github-actions]

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (7178588) to head (3b7f3d6).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55339      +/-   ##
==========================================
+ Coverage   88.38%   88.41%   +0.02%     
==========================================
  Files         652      652              
  Lines      186740   186714      -26     
  Branches    36036    36031       -5     
==========================================
+ Hits       165058   165078      +20     
+ Misses      14934    14896      -38     
+ Partials     6748     6740       -8     

Files with missing lines	Coverage Δ
lib/internal/test_runner/coverage.js	64.54% <100.00%> (+0.82%)	⬆️

... and 34 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63027/

[RedYetiDev]

@RafaelGSS said that he'll do a final sync with main later today. It's imperative that this fix lands before that sync. If not, --enable-source-maps with coverage reporting will be broken.

[cjihrig]

We need a green CI first.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63030/

[RafaelGSS]

@RafaelGSS said that he'll do a final sync with main later today. It's imperative that this fix lands before that sync. If not, --enable-source-maps with coverage reporting will be broken.

I can drop the original commit if this doesn't land. No need to rush if CI isn't green

[RedYetiDev]

If this isn't green by the time you do your final sync, that's probably the best idea. Thanks!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63048/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/55339
✔  Done loading data for nodejs/node/pull/55339
----------------------------------- PR info ------------------------------------
Title      Revert "test_runner: ignore unmapped lines for coverage" (#55339)
Author     Aviv Keller <redyetidev@gmail.com> (@RedYetiDev)
Branch     RedYetiDev:revert-55228-issue-55106 -> nodejs:main
Labels     test, fast-track, author ready, needs-ci, revert, dont-land-on-v18.x, test_runner, dont-land-on-v20.x, dont-land-on-v22.x
Commits    1
 - Revert "test_runner: ignore unmapped lines for coverage"
Committers 1
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/55339
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55339
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 09 Oct 2024 17:59:26 GMT
   ✔  Approvals: 2
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/55339#pullrequestreview-2357863538
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55339#pullrequestreview-2358022594
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 6 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-10-11T08:57:38Z: https://ci.nodejs.org/job/node-test-pull-request/63048/
- Querying data for job/node-test-pull-request/63048/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11291355072

[nodejs-github-bot]

Landed in ccd4faf