os: improve path check with direct index access #55434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
RedYetiDev
reviewed
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55434 +/- ##
==========================================
- Coverage 88.40% 88.39% -0.02%
==========================================
Files 653 653
Lines 187604 187596 -8
Branches 36119 36113 -6
==========================================
- Hits 165849 165822 -27
- Misses 14983 14992 +9
- Partials 6772 6782 +10
|
lpinca
approved these changes
Oct 18, 2024
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
|
test/parallel/test-debugger-break.js This test passed in my local environment, this is a flakky? |
lpinca
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
|
CI failures are unrelated to this patch |
juanarbol
approved these changes
Oct 31, 2024
github-actions
bot
removed
the
request-ci
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 81859cf |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55434 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 5, 2024
PR-URL: #55434 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55434 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55434 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55434 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55434 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced String.prototype.endsWith with manual string length and index checks for performance improvements.