test: refactor some esm tests #55472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55472 +/- ##
==========================================
- Coverage 88.42% 88.41% -0.02%
==========================================
Files 653 653
Lines 187498 187498
Branches 36100 36098 -2
==========================================
- Hits 165791 165772 -19
- Misses 14957 14966 +9
- Partials 6750 6760 +10 |
jasnell
approved these changes
Oct 20, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
atlowChemi
approved these changes
Oct 24, 2024
aduh95
added
commit-queue
jasnell
reviewed
Nov 5, 2024
| import { mustCall } from '../common/index.mjs'; | ||
| import { strictEqual } from 'assert'; | ||
| import '../common/index.mjs'; | ||
| import assert from 'node:assert'; | ||
|
|
||
| import { importFixture } from '../fixtures/pkgexports.mjs'; |
There was a problem hiding this comment.
While we're making changes in tests, it would be nice if we could start adding comments that describe the expected tested behavior or make use of the node:test API and provide descriptive names for the tests.
jasnell
approved these changes
Nov 5, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ecc6238 |
aduh95
added a commit
that referenced
this pull request
Nov 6, 2024
PR-URL: #55472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
added a commit
that referenced
this pull request
Nov 6, 2024
PR-URL: #55472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests were using unusual patterns, making them a bit hard to read.