test: increase coverage of pathToFileURL
#55493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55493 +/- ##
==========================================
+ Coverage 88.41% 88.42% +0.01%
==========================================
Files 653 654 +1
Lines 187437 187662 +225
Branches 36074 36127 +53
==========================================
+ Hits 165723 165946 +223
- Misses 14949 14952 +3
+ Partials 6765 6764 -1 |
anonrig
approved these changes
Oct 22, 2024
Co-authored-by: Livia Medeiros <livia@cirno.name>
LiviaMedeiros
approved these changes
Oct 26, 2024
aduh95
added
the
author ready
github-actions
bot
removed
the
request-ci
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5d4fee8 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR-URL: #55493 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55493 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #55476, we're changing the implementation of
pathToFileURLto something more performant. In an early implementation, I realized some char were swallowed, but we didn't have a test to catch that. This PR is adding some additional test cases to catch this kind of bug.