Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: allow users to reopen stale issues via commands #55498

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

This is a draft as I'd love some opinions on whether this is behavior the project would like to support.

@ljharb pointed out in this thread that it would be ideal if we "can offer a stalebot command that anyone can use to reopen [the issue]".

This is a basic implemention of such commands, so I'd love some opinions on whether this behavior we'd want to support.


(@ljharb do you have anything to add?)

@RedYetiDev RedYetiDev marked this pull request as draft October 23, 2024 13:16
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 23, 2024
@RedYetiDev
Copy link
Member Author

BTW the cons of this is that it may slow down our actions by a few seconds, if a lot of users are commenting at the same time, and it'll clog the list of actions that ran at https://github.com/nodejs/node/actions

Also see #54672

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks

@RedYetiDev RedYetiDev marked this pull request as ready for review October 24, 2024 21:30
@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2024
@bnb
Copy link
Contributor

bnb commented Nov 7, 2024

+1 but this might be something we want the @nodejs/tsc to review as it does fundamentally change how we manage issues.

@RedYetiDev
Copy link
Member Author

Also, once this lands, we should look into landing #54672, and similar PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants