Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage for ServerResponse #55711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: improve test coverage for ServerResponse #55711

wants to merge 1 commit into from
+9 −1

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 4, 2024
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63413/

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (32ff100) to head (aab60b4).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55711   +/-   ##
=======================================
  Coverage   88.39%   88.40%           
=======================================
  Files         654      654           
  Lines      187560   187655   +95     
  Branches    36087    36115   +28     
=======================================
+ Hits       165800   165893   +93     
+ Misses      14996    14994    -2     
- Partials     6764     6768    +4

see 24 files with indirect coverage changes

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63416/

lpinca
lpinca approved these changes Nov 4, 2024
View reviewed changes
test/parallel/test-http-write-head.js Outdated Show resolved Hide resolved
@juanarbol
test: improve test coverage for ServerResponse
aab60b4 
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63431/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanarbol @nodejs-github-bot @lpinca