Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarity to available addon options #55715

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

preveen-stack
Copy link
Contributor

bullet pointed addon optons; wording clarity; fixes typo

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Nov 4, 2024
@preveen-stack preveen-stack force-pushed the doc-addons-clarity branch 2 times, most recently from 19f4b3f to 3460c5c Compare November 4, 2024 08:32
doc/api/addons.md Outdated Show resolved Hide resolved
bullet pointed addon optons; wording clarity; fixes typo
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 98e5693 into nodejs:main Nov 6, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 98e5693

@preveen-stack preveen-stack deleted the doc-addons-clarity branch November 6, 2024 09:37
aduh95 pushed a commit that referenced this pull request Nov 6, 2024
bullet pointed addon optons; wording clarity; fixes typo

PR-URL: #55715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 6, 2024
bullet pointed addon optons; wording clarity; fixes typo

PR-URL: #55715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
bullet pointed addon optons; wording clarity; fixes typo

PR-URL: nodejs#55715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants