-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarity to available addon options #55715
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
preveen-stack:doc-addons-clarity
Nov 6, 2024
Merged
doc: clarity to available addon options #55715
nodejs-github-bot
merged 1 commit into
nodejs:main
from
preveen-stack:doc-addons-clarity
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
Issues and PRs related to native addons.
doc
Issues and PRs related to the documentations.
labels
Nov 4, 2024
preveen-stack
force-pushed
the
doc-addons-clarity
branch
2 times, most recently
from
November 4, 2024 08:32
19f4b3f
to
3460c5c
Compare
bullet pointed addon optons; wording clarity; fixes typo
preveen-stack
force-pushed
the
doc-addons-clarity
branch
from
November 4, 2024 09:21
3460c5c
to
4f5a0fd
Compare
gireeshpunathil
approved these changes
Nov 4, 2024
aduh95
approved these changes
Nov 6, 2024
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Nov 6, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 6, 2024
Landed in 98e5693 |
aduh95
pushed a commit
that referenced
this pull request
Nov 6, 2024
bullet pointed addon optons; wording clarity; fixes typo PR-URL: #55715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 6, 2024
bullet pointed addon optons; wording clarity; fixes typo PR-URL: #55715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
bullet pointed addon optons; wording clarity; fixes typo PR-URL: nodejs#55715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addons
Issues and PRs related to native addons.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bullet pointed addon optons; wording clarity; fixes typo