Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- #55727

Closed
wants to merge 1 commit into from
Closed

- #55727

wants to merge 1 commit into from
+12 −27

Conversation

alexsch01
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Nov 5, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Nov 5, 2024 •
edited
Loading

Please cherry pick my original commit instead of doing git revert.

@RedYetiDev
Copy link
Member

RedYetiDev commented Nov 5, 2024 •
edited
Loading

Additionally, this might not even need a backport PR if the cherry pick lands cleanly?

I've added the appropriate labels to the original PR

@alexsch01 alexsch01 closed this Nov 5, 2024
@alexsch01 alexsch01 deleted the v20.x-staging branch November 5, 2024 16:13
@alexsch01 alexsch01 changed the title [v20.x] Revert "console: colorize console error and warn" - Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsch01 @RedYetiDev @nodejs-github-bot