Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- #55729

Closed
wants to merge 1 commit into from
Closed

- #55729

wants to merge 1 commit into from
+12 −27

Conversation

alexsch01
Copy link
Contributor

@alexsch01 alexsch01 commented Nov 5, 2024 •
edited
Loading

@RedYetiDev @alexsch01
Revert "console: colorize console error and warn"
3b9a6cd 
This reverts commit a833c9e.

PR-URL: #54677
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Nov 5, 2024
@alexsch01 alexsch01 changed the title Revert "console: colorize console error and warn" [v20.x] Revert "console: colorize console error and warn" Nov 5, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Nov 5, 2024 •
edited
Loading

Please change the base branch to v20.x-staging.

Again, I don't think this even needs a backport PR, as the commit lands cleanly, and can be included in the next release

@alexsch01 alexsch01 deleted the branch nodejs:v20.x November 5, 2024 17:12
@alexsch01 alexsch01 closed this Nov 5, 2024
@alexsch01 alexsch01 deleted the v20.x branch November 5, 2024 17:12
@alexsch01
Copy link
Contributor Author

@RedYetiDev does renaming my branch and doing another PR work?

@RedYetiDev
Copy link
Member

RedYetiDev commented Nov 5, 2024 •
edited
Loading

IMHO I would hold off on the backport PR, and see if it is even needed. I'd wait until v20.X is prepared, and then see if it's even needed

@alexsch01 alexsch01 changed the title [v20.x] Revert "console: colorize console error and warn" - Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsch01 @RedYetiDev @nodejs-github-bot