doc: add esm path import #55745
Merged
doc: add esm path import #55745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedYetiDev
added
the
fast-track
nodejs-github-bot
added
doc
|
Fast-track has been requested by @RedYetiDev. Please 👍 to approve. |
RedYetiDev
added
the
commit-queue-squash
lpinca
approved these changes
Nov 6, 2024
atlowChemi
approved these changes
Nov 7, 2024
UlisesGascon
approved these changes
Nov 7, 2024
RedYetiDev
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55745 ✔ Done loading data for nodejs/node/pull/55745 ----------------------------------- PR info ------------------------------------ Title doc: add esm path import (#55745) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:patch-910404 -> nodejs:main Labels doc, path, fast-track, author ready, commit-queue-squash Commits 2 - doc: add esm path import - fixup! Committers 1 - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/55745 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55745 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 06 Nov 2024 12:22:58 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55745#pullrequestreview-2419489384 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55745#pullrequestreview-2419861359 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/55745#pullrequestreview-2421249663 ℹ This PR is being fast-tracked ✘ This PR needs to wait 16 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11729931193 |
|
Landed in daf5346 |
aduh95
pushed a commit
that referenced
this pull request
Nov 9, 2024
PR-URL: #55745 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55745 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast-tracking because this is a relatively simple change to implement, and IMO it doesn't need much deliberation