src: use wide string for findPackageJson onWindows #55861
+80
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
Can you add a test? |
islandryu
force-pushed
the
fix/nonAscii
branch
from
341da94
to
19f43e3
Compare
Fix error when searching for package.json with non-ASCII characters in paths Fixes: nodejs#55773
islandryu
force-pushed
the
fix/nonAscii
branch
from
19f43e3
to
d0e4106
Compare
RedYetiDev
reviewed
Nov 15, 2024
test/parallel/test-non-ascii.js
Outdated
Comment on lines
11
to
15
| fs.mkdirSync(tmpdir.resolve('12月'), { recursive: true }); | ||
| fs.writeFileSync( | ||
| tmpdir.resolve('12月/index.js'), | ||
| "console.log('12月');", | ||
| ); |
There was a problem hiding this comment.
This can be a fixture, right?
There was a problem hiding this comment.
Thank you. I should do that.
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
RedYetiDev
reviewed
Nov 15, 2024
| 'use strict'; | ||
|
|
||
| const fs = require('node:fs'); | ||
| const common = require('../common'); |
There was a problem hiding this comment.
Common must be the first import. FWIW running make lint will catch this.
There was a problem hiding this comment.
sorry for the lint error.
I've fixed it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55861 +/- ##
=======================================
Coverage 88.42% 88.43%
=======================================
Files 654 654
Lines 187852 187850 -2
Branches 36134 36134
=======================================
+ Hits 166102 166117 +15
+ Misses 14989 14982 -7
+ Partials 6761 6751 -10
|
anonrig
reviewed
Nov 16, 2024
| std::wstring ConvertToWideString(const std::string& str); | ||
|
|
||
| #define BufferValueToPath(str) \ | ||
| std::filesystem::path(ConvertToWideString(str.ToString())) |
There was a problem hiding this comment.
These macros are unnecessary. Also, str.ToString() makes an unnecessary copy, even tho, the function is const std::string&. str.ToStringView() would remove the unnecessary copy here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error when searching for package.json with non-ASCII characters in paths
Fixes: #55773