sqlite: deps include sqlite3ext.h
#56010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dependencies
himself65
force-pushed
the
himself65/20241126/include_ext
branch
from
47ea81c
to
0c383db
Compare
himself65
changed the title
sqlite3ext.hsqlite3ext.h
cjihrig
approved these changes
Nov 27, 2024
aduh95
added
the
author ready
himself65
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56010 ✔ Done loading data for nodejs/node/pull/56010 ----------------------------------- PR info ------------------------------------ Title sqlite: deps include `sqlite3ext.h` (#56010) Author Alex Yang <himself65@outlook.com> (@himself65) Branch himself65:himself65/20241126/include_ext -> nodejs:main Labels tools, author ready, needs-ci, dependencies, sqlite Commits 1 - sqlite: deps include `sqlite3ext.h` Committers 1 - Alex Yang <himself65@outlook.com> PR-URL: https://github.com/nodejs/node/pull/56010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 27 Nov 2024 00:30:11 GMT ✔ Approvals: 1 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56010#pullrequestreview-2465240184 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12077031263 |
github-actions
bot
removed
the
request-ci
juanarbol
approved these changes
Nov 29, 2024
himself65
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 22792b8 |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
PR-URL: #56010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requirement of #53900, I need this header file to build extension from source code