build: allow overriding clang usage #56016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
the
embedding
nodejs-github-bot
added
build
anonrig
approved these changes
Nov 27, 2024
aduh95
force-pushed
the
allow-configure-clang
branch
from
105bfd3
to
3380af0
Compare
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
codebytere
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56016 ✔ Done loading data for nodejs/node/pull/56016 ----------------------------------- PR info ------------------------------------ Title build: allow overriding clang usage (#56016) Author Shelley Vohr <shelley.vohr@gmail.com> (@codebytere) Branch codebytere:allow-configure-clang -> nodejs:main Labels build, embedding, author ready, needs-ci Commits 1 - build: allow overriding clang usage Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/56016 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56016 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: allow overriding clang usage ℹ This PR was created on Wed, 27 Nov 2024 09:18:40 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56016#pullrequestreview-2464816446 ✘ This PR needs to wait 42 more hours to land (or 0 hours if there is one more approval) ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-11-27T20:14:08Z: https://ci.nodejs.org/job/node-test-pull-request/63728/ - Querying data for job/node-test-pull-request/63728/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12121376881 |
richardlau
approved these changes
Dec 2, 2024
codebytere
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3b6da7c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs 6e0a2bb5
Refs electron/electron#44189
The above commit configures the value for
clangusage at build time which doesn't work in Electron. It depends on the environment where the headers got generated, which doesn't always reflect the platform where the binary was built for us.This isn't an issue for Node.js since node-gyp will use the result of
process.configthat reflects the environment in which the binary got built.To fix this, allow overriding clang usage.