Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update undici to 7.0.0 #56070

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Nov 29, 2024

This is an automated update of undici to 7.0.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 29, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 29, 2024

What's the semverness of this @nodejs/undici ?

@mcollina mcollina added semver-major PRs that contain breaking changes and should be released in the next major version. notable-change PRs with changes that should be highlighted in changelogs. labels Nov 29, 2024
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @mcollina.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@mcollina
Copy link
Member

mcollina commented Nov 29, 2024

I would consider it semver-major, or at least something to not backport on lts lines.

The major relevant change are

Stricter fetch() spec compliance

Back when we first considered fetch() to Node.js, we needed to provide a migration path for all the users of the various polyfills that where on the NPM registry. Therefore, we added support for third party Blob, FormData, and AbortController. This support was tested but not really documented. However, this causes quite a few maintenance issues as those polyfills do not follow the spec.

In Undici v7, we decided to remove support for those entirely in our fetch() implementation. Therefore, only the provided classes will work with it.

Updates to llhttp v9

The new version of the HTTP parser switches to an always strict parsing logic.

If you only connect to HTTP specification compliant servers, this change will not impact you. If this is an important issue for you, we recommend checking nodejs/undici#2678 out, and contribute back.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (4efb7ae) to head (f119991).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56070   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files         656      656           
  Lines      188988   189000   +12     
  Branches    35988    35990    +2     
=======================================
+ Hits       166302   166326   +24     
+ Misses      15848    15836   -12     
  Partials     6838     6838           

see 23 files with indirect coverage changes

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it updates llhttp to v9. Is it a notable change?

@mcollina
Copy link
Member

It is!

@mcollina
Copy link
Member

After this lands, we could add an experimental WebSocketStream implementation to Node.js as well.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/56070
✔  Done loading data for nodejs/node/pull/56070
----------------------------------- PR info ------------------------------------
Title      deps: update undici to 7.0.0 (#56070)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-undici -> nodejs:main
Labels     semver-major, notable-change, author ready, needs-ci, dependencies, commit-queue-squash
Commits    2
 - deps: update undici to 7.0.0
 - deps: update undici to 7.0.0
Committers 1
 - Node.js GitHub Bot <github-bot@iojs.org>
PR-URL: https://github.com/nodejs/node/pull/56070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 29 Nov 2024 09:12:39 GMT
   ✔  Approvals: 4
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/56070#pullrequestreview-2469649863
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56070#pullrequestreview-2469755387
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/56070#pullrequestreview-2471340963
   ✔  - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/56070#pullrequestreview-2470117914
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-11-29T10:41:07Z: https://ci.nodejs.org/job/node-test-pull-request/63771/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - deps: update undici to 7.0.0
- Querying data for job/node-test-pull-request/63771/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12107971135

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 1, 2024
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 47b80c2 into main Dec 2, 2024
75 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 47b80c2

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch December 2, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants