src: add async context frame to AsyncResource #56082
Merged
+9
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add member to hold the async context frame to AsyncResource to avoid the need for the async_resource_context_frames_ map in env. Semver major because it changes ABI.
Flarna
added
semver-major
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56082 +/- ##
=======================================
Coverage 87.99% 88.00%
=======================================
Files 656 656
Lines 188988 188970 -18
Branches 35988 35990 +2
=======================================
- Hits 166302 166299 -3
+ Misses 15848 15842 -6
+ Partials 6838 6829 -9
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Nov 29, 2024
anonrig
approved these changes
Nov 30, 2024
anonrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 58982d7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add member to hold the async context frame to
AsyncResourceto avoid the need for theasync_resource_context_frames_map inenv.Semver major because it changes ABI.
Continuation of #54879.
Seems to be a good time now as
AsyncContextFrameis now default for ALS (see #55552).