Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: support blocklist in udp #56087

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

theanarkh
Copy link
Contributor

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@theanarkh theanarkh marked this pull request as draft November 29, 2024 20:45
@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (4211ab5) to head (8e6556f).
Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
lib/dgram.js 83.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56087      +/-   ##
==========================================
- Coverage   88.00%   88.00%   -0.01%     
==========================================
  Files         656      656              
  Lines      189103   189138      +35     
  Branches    35999    36016      +17     
==========================================
+ Hits       166421   166444      +23     
+ Misses      15860    15854       -6     
- Partials     6822     6840      +18     
Files with missing lines Coverage Δ
lib/dgram.js 97.61% <83.33%> (+0.25%) ⬆️

... and 23 files with indirect coverage changes

@theanarkh theanarkh force-pushed the support_blocklist_in_udp branch from e00dee2 to 51c92f2 Compare November 30, 2024 03:01
@theanarkh theanarkh force-pushed the support_blocklist_in_udp branch from 51c92f2 to 8e6556f Compare December 6, 2024 17:20
@theanarkh theanarkh marked this pull request as ready for review December 6, 2024 17:21
@theanarkh theanarkh added the review wanted PRs that need reviews. label Dec 10, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed review wanted PRs that need reviews. labels Dec 14, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit a50f3d5 into nodejs:main Dec 15, 2024
86 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a50f3d5

aduh95 pushed a commit that referenced this pull request Dec 18, 2024
PR-URL: #56087
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca lpinca added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 18, 2024
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
PR-URL: #56087
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit that referenced this pull request Dec 18, 2024
Notable changes:

crypto:
  * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142
dgram:
  * (SEMVER-MINOR) support blocklist in udp (theanarkh) #56087
doc:
  * stabilize util.styleText (Rafael Gonzaga) #56265
module:
  * (SEMVER-MINOR) add prefix-only modules to `module.builtinModules` (Jordan Harband) #56185
  * (SEMVER-MINOR) only emit require(esm) warning under --trace-require-module (Joyee Cheung) #56194
  * (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
  * (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
report:
  * (SEMVER-MINOR) fix typos in report keys and bump the version (Yuan-Ming Hsu) #56068
sqlite:
  * (SEMVER-MINOR) aggregate constants in a single property (Edigleysson Silva (Edy)) #56213
src,lib:
  * (SEMVER-MINOR) stabilize permission model (Rafael Gonzaga) #56201

PR-URL: #56310
aduh95 added a commit that referenced this pull request Dec 19, 2024
Notable changes:

crypto:
  * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142
dgram:
  * (SEMVER-MINOR) support blocklist in udp (theanarkh) #56087
doc:
  * stabilize util.styleText (Rafael Gonzaga) #56265
module:
  * (SEMVER-MINOR) add prefix-only modules to `module.builtinModules` (Jordan Harband) #56185
  * (SEMVER-MINOR) only emit require(esm) warning under --trace-require-module (Joyee Cheung) #56194
  * (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
  * (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
report:
  * (SEMVER-MINOR) fix typos in report keys and bump the version (Yuan-Ming Hsu) #56068
sqlite:
  * (SEMVER-MINOR) aggregate constants in a single property (Edigleysson Silva (Edy)) #56213
src,lib:
  * (SEMVER-MINOR) stabilize permission model (Rafael Gonzaga) #56201

PR-URL: #56310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants