test_runner: introduce NODE_TEST_WORKER_ID for improved concurrent te… #56091
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st execution Added a new environment variable, `NODE_TEST_WORKER_ID`, which ranges from 1 to N when `--experimental-test-isolation=process` is enabled and defaults to 1 when `--experimental-test-isolation=none` is used.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #55842
Added a new environment variable,
NODE_TEST_WORKER_ID, which ranges from 1 to N when--experimental-test-isolation=processis enabled and defaults to 1 when--experimental-test-isolation=noneis used.Before merging, I want to add some tests but haven't come up with a good approach yet. Here's what I aim to test:
--experimental-test-isolation=processis enabled, verify thatNODE_TEST_WORKER_IDranges from 1 to N.--experimental-test-isolation=noneis used, ensure thatNODE_TEST_WORKER_IDis set to 1.Any suggestions on how to create such tests would be greatly appreciated!