Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include typo in 'unhandledRejection' example #5654

Closed
wants to merge 1 commit into from
Closed

doc: include typo in 'unhandledRejection' example #5654

wants to merge 1 commit into from

Conversation

r1b
Copy link
Contributor

@r1b r1b commented Mar 11, 2016

Affected core subsystem(s)

doc

Description of change

Closes #5644

@mscdex mscdex added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Mar 11, 2016
@jasnell
Copy link
Member

jasnell commented Mar 11, 2016

LGTM

@Trott
Copy link
Member

Trott commented Mar 11, 2016

LGTM. If you're up for it, maybe change the commit message to be Fixes: <URL to GitHub issue> as that is our metadata convention in the commit messages. (And if you're not up for it, whoever lands this will probably do that.)

@Fishrock123
Copy link
Contributor

lgtm

@benjamingr
Copy link
Member

When I wrote that doc, the prase was intentional - so this definitely fixes an introduced problem - LGTM.

Thanks for the contribution!

claudiorodriguez pushed a commit that referenced this pull request Mar 12, 2016
@r1b @claudiorodriguez
doc: include typo in 'unhandledRejection' example
e2488fa 
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@claudiorodriguez
Copy link
Contributor

Landed in e2488fa

@evanlucas evanlucas mentioned this pull request Mar 14, 2016
Closed
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
@r1b @evanlucas
doc: include typo in 'unhandledRejection' example
e0ceb68 
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
Merged
rvagg pushed a commit that referenced this pull request Mar 16, 2016
@r1b @rvagg
doc: include typo in 'unhandledRejection' example
dd12661 
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@r1b
doc: include typo in 'unhandledRejection' example
1352794 
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@r1b
doc: include typo in 'unhandledRejection' example
80bae47 
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@r1b
doc: include typo in 'unhandledRejection' example
5176346 
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@r1b @jasnell @Trott @Fishrock123 @benjamingr @claudiorodriguez @mscdex @MylesBorins