Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add thekemkid to collaborators #5667

Merged
merged 1 commit into from
Mar 12, 2016

Conversation

GlenTiki
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

Description of change

Adding myself to the collaborator list

@GlenTiki GlenTiki added the doc Issues and PRs related to the documentations. label Mar 11, 2016
@benjamingr
Copy link
Member

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

PR-URL: https://github.com/nodejs/node/pull/5667

LGTM!

@cjihrig
Copy link
Contributor

cjihrig commented Mar 12, 2016

The second line of the commit message should be blank. Other than that, LGTM.

PR-URL: nodejs#5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@GlenTiki GlenTiki merged commit 4daab7f into nodejs:master Mar 12, 2016
@benjamingr
Copy link
Member

@thekemkid hey, in the future please see https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests - we don't merge using the GitHub merge button. I'm not sure if that's what you did here - but just for future reference.

@GlenTiki
Copy link
Contributor Author

I didn't use the button, as there's no commit (EDIT: merge) message O.o

I rebased my branch onto a local master and pushed that to upstream. I expected to have to close this after pushing, but github closed for me.

@rvagg
Copy link
Member

rvagg commented Mar 14, 2016

Welcome @thekemkid! Good to have you on board!

evanlucas pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
rvagg pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

🎉

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants