Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: prevent URLPattern property getters from crashing with invalid this #56877

Merged
merged 1 commit into from
Feb 4, 2025
Merged

src: prevent URLPattern property getters from crashing with invalid this #56877

merged 1 commit into from
Feb 4, 2025

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 2, 2025

See the test. It would fail with an abort/crash before without this change.

@jasnell jasnell requested review from anonrig and legendecas February 2, 2025 03:25
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 2, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the jasnell/fix-urlpattern-getters-crash branch from 5b15120 to bbf2adf Compare February 2, 2025 04:52
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2025
legendecas
legendecas reviewed Feb 2, 2025
View reviewed changes
src/node_url_pattern.cc Outdated Show resolved Hide resolved
@legendecas legendecas added whatwg-urlpattern and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 2, 2025
@legendecas

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the jasnell/fix-urlpattern-getters-crash branch from bbf2adf to ef3889b Compare February 2, 2025 16:35
@jasnell jasnell requested a review from legendecas February 2, 2025 16:35
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 2, 2025
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64930/ 💚

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit a091f48 into nodejs:main Feb 4, 2025
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a091f48

targos pushed a commit that referenced this pull request Feb 5, 2025
@jasnell @targos
src: prevent URLPattern property accessors from crashing on invalid this
edb194b 
PR-URL: #56877
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. whatwg-urlpattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @legendecas @anonrig