Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: prioritize current directory for local lookup #5689

Closed
wants to merge 2 commits into from
Closed

module: prioritize current directory for local lookup #5689

wants to merge 2 commits into from

Commits on Mar 29, 2016

  1. module: prioritize current dir for local lookups 

    This fixes a bug where a 3rd party module found in node_modules,
would be preferred over a ./local module with the same name.

Fixes: nodejs#5684
PR-URL: nodejs#5689
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @phillipj
    phillipj committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    03f4304 View commit details
    Browse the repository at this point in the history

  2. test: update test-repl-require for local paths 

    Currently we are not testing that resolution of local paths is
resolved first in the repl. This addition to `test-repl-require`
adds an additional fixture an ensures we won't regress in the future

PR-URL: nodejs#5689
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @phillipj
    Myles Borins authored and phillipj committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    fc19540 View commit details
    Browse the repository at this point in the history