Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.x backport] typescript syntax detection #56912

Merged
merged 8 commits into from
Feb 6, 2025

Conversation

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

Sorry, something went wrong.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Feb 4, 2025
@marco-ippolito marco-ippolito marked this pull request as draft February 4, 2025 12:50
@marco-ippolito marco-ippolito added the strip-types Issues or PRs related to strip-types support label Feb 4, 2025
@marco-ippolito marco-ippolito marked this pull request as ready for review February 4, 2025 15:00
@aduh95 aduh95 changed the title [v22.x] backport typescript syntax detection [v22.x backport] typescript syntax detection Feb 4, 2025
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

aduh95 added a commit that referenced this pull request Feb 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This reverts commit b5d8cbd.

PR-URL: #56912
@aduh95 aduh95 requested a review from a team as a code owner February 6, 2025 00:11
marco-ippolito and others added 8 commits February 6, 2025 01:14
PR-URL: nodejs#56285
Backport-PR-URL: nodejs#56912
Refs: nodejs/typescript#17
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs#56359
Backport-PR-URL: nodejs#56912
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: nodejs#56358
Backport-PR-URL: nodejs#56912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs#56358
Backport-PR-URL: nodejs#56912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs#56358
Backport-PR-URL: nodejs#56912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs#56394
Backport-PR-URL: nodejs#56912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: nodejs#56610
Backport-PR-URL: nodejs#56912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: nodejs#56646
Backport-PR-URL: nodejs#56912
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 force-pushed the backport-typescript branch from 60a6658 to bae4b2e Compare February 6, 2025 00:16
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2025
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 merged commit bae4b2e into nodejs:v22.x-staging Feb 6, 2025
55 of 57 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Feb 6, 2025

Landed in 8cbb7cc...bae4b2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants