Reduce tarball size, v2 #5695
Reduce tarball size, v2 #5695
Conversation
|
CC: @nodejs/build |
|
Do the linting-related files really take up that much space though compared to the other things being removed in this PR? |
|
@mscdex 8% tarball size (9% xz). |
|
Should this be labeled |
|
@ChALkeR because we're removing |
rvagg
added
the
semver-major
| @@ -261,6 +261,7 @@ goto jslint | |||
|
|
|||
| :jslint | |||
| if not defined jslint goto exit | |||
| if not exist tools\eslint\bin\eslint.js goto exit | |||
There was a problem hiding this comment.
thinking you should probably be as nice here as you are in the Makefile about what's wrong
|
semver-major is a good idea since it's a change in expectations for users building from source lgtm |
| else | ||
| test-v8 test-v8-intl test-v8-benchmarks test-v8-all: | ||
| @echo "Testing v8 is not available through the source tarball." | ||
| @echo "Use the git repo instead: $ git clone https://github.com/nodejs/node.git" |
|
LGTM. |
|
LGTM with @bnoordhuis' comments addressed. |
| @@ -583,7 +593,7 @@ bench-idle: | |||
|
|
|||
| jslint: | |||
| $(NODE) tools/eslint/bin/eslint.js benchmark lib src test tools/doc \ | |||
| tools/eslint-rules --rulesdir tools/eslint-rules | |||
| tools/eslint-rules --rulesdir tools/eslint-rules | |||
There was a problem hiding this comment.
@Trott I think you committed these leading spaces, which can be problematic in a Makefile, thought it seems it didn't matter here. This change here could've been avoided with a Editorconfig plugin in your editor 😉
This removes the ability to run linting from the source tarball, rationale being that developers should use a git clone instead. Also, fix the path of removing artifacts from the openssl dependency since it now lives in `deps/openssl/openssl/`. Tarballs shrink with ~10%. PR-URL: nodejs#5695 Fixes: nodejs#5618 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: thefourtheye <thechargingvolcano@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
jbergstroem
force-pushed
the
feature/slimmer-tarballs-v2
branch
from
c67846b
to
90a5fc2
Compare
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
build, deps, tools
Description of change
Reduce the nodejs tarball size with another ~10% (it's grown pretty fast over the last year). The distinction we're making here is that developers should opt for git instead of tarballs, but the test suite should still be able to run (therefore verifying the generated binary). This means that stuff like linters or test suites in
deps/should go.