Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use SafeMap primordial for ActiveAsyncContextFrame #57670

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gurgunday
Copy link
Member

Not sure if this was intentional, but (In)ActiveAsyncContextFrame seems to extend Map without using primordials

Tracked down the change to ef6b9ff

Cc @bengl

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 29, 2025
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (af75d04) to head (d2b3308).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #57670   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         630      630           
  Lines      185055   185056    +1     
  Branches    36221    36220    -1     
=======================================
+ Hits       166984   166989    +5     
  Misses      11043    11043           
+ Partials     7028     7024    -4     
Files with missing lines Coverage Δ
lib/internal/async_context_frame.js 76.62% <100.00%> (+0.30%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants